Changeset 1374:50299dadf2e0 for alias.c

Timestamp:

1999-11-17 12:22:33 (9 years ago)

Author:

Thomas Roessler <roessler@…>

Branch:

HEAD

Message:

Fix the address sanitizer. You should now be able to auto-create an
alias for someone like "Jon K. Hellan" <hellan@…>.

Files:

• alias.c (modified) (2 diffs)

alias.c

@@ -129 +129 @@
 }
 
-/* if someone has an address like
+/* 
+ * if someone has an address like
  *      From: Michael `/bin/rm -f ~` Elkins <me@cs.hmc.edu>
  * and the user creates an alias for this, Mutt could wind up executing
@@ -141 +142 @@
  *      alias me Michael \\`/bin/rm -f ~\\` Elkins <me@cs.hmc.edu>
  * which still gets evaluated because the double backslash is not a quote.
+ * 
+ * Additionally, we need to quote ' and " characters - otherwise, mutt will
+ * interpret them on the wrong parsing step.
+ * 
+ * $ wants to be quoted since it may indicate the start of an environment
+ * variable.
  */
+
 static void write_safe_address (FILE *fp, char *s)
 {
   while (*s)
   {
-    if (*s == '\\' || *s == '`')
+    if (*s == '\\' || *s == '`' || *s == '\'' || *s == '"'
+        || *s == '$')
       fputc ('\\', fp);
     fputc (*s, fp);