Changeset 2435:dd9866e2059f for commands.c

Timestamp:

2001-06-05 00:55:55 (7 years ago)

Author:

Thomas Roessler <roessler@…>

Branch:

HEAD

Message:

Check mutt_create_filter*'s return value for errors. This should
avoid a bunch of possible crashes.

Files:

• commands.c (modified) (5 diffs)

commands.c

@@ -125 +125 @@
     {
       mutt_error (_("Cannot create display filter"));
-      fclose (fpfilterout);
+      safe_fclose (&fpfilterout);
       unlink (tempfile);
       return 0;
@@ -325 +325 @@
 #endif
 
-    thepid = mutt_create_filter (cmd, &fpout, NULL, NULL);
+    if ((thepid = mutt_create_filter (cmd, &fpout, NULL, NULL)) < 0)
+    {
+      mutt_perror _("Can't create filter process");
+      return 1;
+    }
+      
     pipe_msg (h, fpout, decode);
-    fclose (fpout);
+    safe_fclose (&fpout);
     rc = mutt_wait_filter (thepid);
   }
@@ -359 +364 @@
           mutt_message_hook (Context, Context->hdrs[Context->v2r[i]], M_MESSAGEHOOK);
           mutt_endwin (NULL);
-          thepid = mutt_create_filter (cmd, &fpout, NULL, NULL);
+          if ((thepid = mutt_create_filter (cmd, &fpout, NULL, NULL)) < 0)
+          {
+            mutt_perror _("Can't create filter process");
+            return 1;
+          }
           pipe_msg (Context->hdrs[Context->v2r[i]], fpout, decode);
           /* add the message separator */
           if (sep)  fputs (sep, fpout);
-          fclose (fpout);
+          safe_fclose (&fpout);
           if (mutt_wait_filter (thepid) != 0)
             rc = 1;
@@ -372 +381 @@
     {
       mutt_endwin (NULL);
-      thepid = mutt_create_filter (cmd, &fpout, NULL, NULL);
+      if ((thepid = mutt_create_filter (cmd, &fpout, NULL, NULL)) < 0)
+      {
+        mutt_perror _("Can't create filter process");
+        return 1;
+      }
       for (i = 0; i < Context->vcount; i++)
       {
@@ -383 +396 @@
         }
       }
-      fclose (fpout);
+      safe_fclose (&fpout);
       if (mutt_wait_filter (thepid) != 0)
         rc = 1;