Changeset 3441:f78b184ef598 for intl

Timestamp:

2003-07-24 11:40:50 (5 years ago)

Author:

Vincent Lefevre <vincent@…>

Branch:

HEAD

Message:

Some functions/macros like isspace take an int and require the
argument to have the value of an unsigned char (or EOF). Under
Solaris, gcc complains when the argument is a char (as this is a
possible bug, on platforms where char is signed, like Solaris). The
attached patch fixes such problems (well, perhaps I've changed more
than necessary, but this doesn't hurt).

Location:

intl

Files:

• l10nflist.c (modified) (2 diffs)
• loadmsgcat.c (modified) (1 diff)
• localealias.c (modified) (4 diffs)

intl/l10nflist.c

@@ -357 +357 @@
 
   for (cnt = 0; cnt < name_len; ++cnt)
-    if (isalnum (codeset[cnt]))
+    if (isalnum ((unsigned char) codeset[cnt]))
       {
         ++len;
 
-        if (isalpha (codeset[cnt]))
+        if (isalpha ((unsigned char) codeset[cnt]))
           only_digit = 0;
       }
@@ -375 +375 @@
 
       for (cnt = 0; cnt < name_len; ++cnt)
-        if (isalpha (codeset[cnt]))
-          *wp++ = tolower (codeset[cnt]);
-        else if (isdigit (codeset[cnt]))
+        if (isalpha ((unsigned char) codeset[cnt]))
+          *wp++ = tolower ((unsigned char) codeset[cnt]);
+        else if (isdigit ((unsigned char) codeset[cnt]))
           *wp++ = codeset[cnt];
 

intl/loadmsgcat.c

@@ -509 +509 @@
 
           nplurals += 9;
-          while (*nplurals != '\0' && isspace (*nplurals))
+          while (*nplurals != '\0' && isspace ((unsigned char) *nplurals))
             ++nplurals;
 #if defined HAVE_STRTOUL || defined _LIBC

intl/localealias.c

@@ -245 +245 @@
       cp = buf;
       /* Ignore leading white space.  */
-      while (isspace (cp[0]))
+      while (isspace ((unsigned char) cp[0]))
         ++cp;
 
@@ -252 +252 @@
         {
           alias = cp++;
-          while (cp[0] != '\0' && !isspace (cp[0]))
+          while (cp[0] != '\0' && !isspace ((unsigned char) cp[0]))
             ++cp;
           /* Terminate alias name.  */
@@ -259 +259 @@
 
           /* Now look for the beginning of the value.  */
-          while (isspace (cp[0]))
+          while (isspace ((unsigned char) cp[0]))
             ++cp;
 
@@ -268 +268 @@
 
               value = cp++;
-              while (cp[0] != '\0' && !isspace (cp[0]))
+              while (cp[0] != '\0' && !isspace ((unsigned char) cp[0]))
                 ++cp;
               /* Terminate value.  */