Changeset 4640:a115f3ac3b62 for muttlib.c

Timestamp:

2006-05-18 10:35:29 (3 years ago)

Author:

Rocco Rutte <pdmef@…>

Branch:

HEAD

Message:

Avoid safe_free() usage and add security checks

Add checks to check_sec.sh for memory functions.

These include a check for use of safe_free() instead of FREE() and a
check whether FREE(&...) is used.

For the former, SAFE_FREE_CHECKED is to be used, for the latter
FREE_CHECKED to avoid messages from check_sec.sh

Files:

• muttlib.c (modified) (7 diffs)

muttlib.c

@@ -292 +292 @@
   FREE (&(*h)->data);
 #endif
-  FREE (h);
+  FREE (h);             /* __FREE_CHECKED__ */
 }
 
@@ -680 +680 @@
   mutt_free_list (&(*p)->in_reply_to);
   mutt_free_list (&(*p)->userhdrs);
-  FREE (p);
+  FREE (p);             /* __FREE_CHECKED__ */
 }
 
@@ -914 +914 @@
           break;
         case 1:         /* yes */
-          FREE (directory);
+          FREE (directory);             /* __FREE_CHECKED__ */
           break;
         case -1:        /* abort */
-          FREE (directory); 
+          FREE (directory);             /* __FREE_CHECKED__ */
           return -1;
         case  2:        /* no */
-          FREE (directory);
+          FREE (directory);             /* __FREE_CHECKED__ */
           return 1;
       }
@@ -1394 +1394 @@
   else
   {
-    safe_free(&b->data);
+    FREE(&b->data);
   }
   memset(b, 0, sizeof(BUFFER));
@@ -1474 +1474 @@
    FREE(&(*p)->data);
    /* dptr is just an offset to data and shouldn't be freed */
-   FREE(p);
+   FREE(p);             /* __FREE_CHECKED__ */
 }
 
@@ -1546 +1546 @@
   regfree ((*pp)->rx);
   FREE (&(*pp)->rx);
-  FREE (pp);
+  FREE (pp);            /* __FREE_CHECKED__ */
 }
 
@@ -1573 +1573 @@
     *list = (*list)->next;
     mutt_free_regexp (&p->rx);
-    safe_free(&p->template);
+    FREE (&p->template);
     FREE (&p);
   }