Changeset 5047:720070fc62e0

Timestamp:

2007-04-02 16:18:37 (22 months ago)

Author:

Brendan Cully <brendan@…>

Branch:

HEAD

Message:

Reset uidnext unconditionally in IMAP new mail check.
Reverts a logic error introduced in [0cb476dc70a7]

Files:

• ChangeLog (modified) (1 diff)
• imap/command.c (modified) (2 diffs)

ChangeLog

@@ -1 @@
-2007-04-02 10:48 -0700  Brendan Cully  <brendan@kublai.com>  (aa6f191cfa10)
+2007-04-02 14:33 -0700  Brendan Cully  <brendan@kublai.com>  (eabef30c9344)
+
+        * imap/imap.c, imap/imap_private.h, imap/message.c, imap/util.c: Fix a
+        segfault in the new mboxcache hcache lookup. idata may not have an
+        associated context, so the cache path must use the account info
+        instead. For harmony with the other hcache callers, make them all
+        canonify the path the same way with imap_hcache_open.
+
+        * imap/imap.c: Fix segfault in new mboxcache hcache check when
+        create is 0
 
         * imap/command.c, imap/imap.c, imap/imap_private.h, imap/message.c:

imap/command.c

@@ -902 +902 @@
         {
           if (oldun < status->uidnext)
-          {
             inc->new = status->unseen;
-            /* forced back to keep detecting new mail until the mailbox is opened */
-            status->uidnext = oldun;
-          }
         }
         else if (!olduv && !oldun)
@@ -914 +910 @@
           inc->new = status->unseen;
 
+        /* forced back to keep detecting new mail until the mailbox is opened */
+        status->uidnext = oldun;
+
         FREE (&value);
         return;