Changeset 5127:eb5db1cd5251 for imap/message.c

Timestamp:

2007-04-12 09:16:06 (21 months ago)

Author:

Brendan Cully <brendan@…>

Branch:

HEAD

Message:

Handle a missing or corrupted header cache entry (closes #2676)
If imap_hcache_get fails, stop parsing the header cache and simply
refetch from that point on.

Files:

• imap/message.c (modified) (2 diffs)

imap/message.c

@@ -162 +162 @@
         }
 
+        /* hole in the header cache */
+        if (!evalhc)
+          continue;
+
         if ((mfhrc = msg_fetch_header (ctx, &h, idata->buf, NULL)) == -1)
           continue;
@@ -191 +195 @@
         }
         else
-          /* bad header in the cache, we'll have to refetch.
-           * TODO: consider the possibility of a holey cache. */
+        {
+          /* bad header in the cache, we'll have to refetch. */
+          dprint (3, (debugfile, "bad cache entry at %d, giving up\n", h.sid - 1));
           imap_free_header_data((void**) (void*) &h.data);
+          evalhc = 0;
+        }
       }
       while (rc != IMAP_CMD_OK && mfhrc == -1);