Changeset 5457:7729b1ad530c for copy.c

Timestamp:

2008-07-10 06:38:25 (5 months ago)

Author:

Aron Griffis <agriffis@…>

Branch:

HEAD

Message:

Unify mutt_write_references

copy.c and sendlib.c have independent and different implementations of writing
references to a file. Choose the one in sendlib since it's conservative with
mallocs and supports trimming the list.

Signed-off-by: Aron Griffis <agriffis@…>

Files:

• copy.c (modified) (2 diffs)

copy.c

@@ -370 +370 @@
       {
         LIST *listp = h->env->in_reply_to;
-        fputs ("In-Reply-To: ", out);
+        fputs ("In-Reply-To:", out);
         for (; listp; listp = listp->next)
         {
+          fputc (' ', out);
           fputs (listp->data, out);
-          fputc (' ', out);
         }
         fputc ('\n', out);
@@ -382 +382 @@
       {
         LIST *listp = h->env->references, *refs = NULL, *t;
-        fputs ("References: ", out);
-
-        /* Mutt stores references in reverse order, thus we create
-         * a reordered refs list that we can put in the headers */
-        for (; listp; listp = listp->next, refs = t)
-        {
-          t = (LIST *)safe_malloc (sizeof (LIST));
-          t->data = listp->data;
-          t->next = refs;
-        }
-
-        for (; refs; refs = refs->next)
-        {
-          fputs (refs->data, out);
-          fputc (' ', out);
-        }
-
-        /* clearing refs from memory */
-        for (t = refs; refs; refs = t->next, t = refs)
-          FREE (&refs);
-
+        fputs ("References:", out);
+        mutt_write_references (h->env->references, out, 0);
         fputc ('\n', out);
       }