Ticket #2942 (new defect)

Opened 16 months ago

Last modified 3 months ago

header cache is still not safe

Reported by: brendan Owned by: pdmef
Priority: major Milestone: 1.6
Component: header cache Version: 1.5.16
Keywords: patch Cc:

Description

The header cache does not properly dump or zero several fields in dump_body, leaving several pointers behind that are likely to be invalid. At first glance, the bad fields seem to include charset, content, next, parts, hdr, and aptr, unless these are reset elsewhere in the code after restore_body.

Attachments

hc-update.diff (0.8 kB) - added by pdmef 5 months ago.

Change History

Changed 5 months ago by pdmef

Add patch updating hcache upon mailbox sync for IMAP, Maildir and MH (can't do it for POP as the ACLs we need to enable for updating to be useful would allow too many operations like editing messages).

Changed 5 months ago by pdmef

(In [b9ac445b035b]) Prevent some pointers of 'struct body' being saved to hcache

This addresses the hcache safety issue but maybe doesn't fix it completely, see #2942. This also prevents mutt from crashing when using a hcache that was synced when syncing the mailbox (updating changed and fully-parsed messages).

Changed 5 months ago by pdmef

Changed 4 months ago by pdmef

  • keywords patch added

Changed 3 months ago by pdmef

  • owner changed from mutt-dev to pdmef
Note: See TracTickets for help on using tickets.