Ticket #3108 (closed defect: fixed)

Opened 3 months ago

Last modified 3 weeks ago

Mutt 1.5.18 "could not copy message"

Reported by: mcba Owned by: mutt-dev
Priority: major Milestone:
Component: mutt Version: 1.5.18
Keywords: patch Cc: mutt-trac@…, sertac.liste@…

Description

Mutt says "could not copy message" whenever I am sent emails with attachments by a particular person. The relevant headers (as revealed by "pine") are:

User-Agent: SquirrelMail? MIME-Version: 1.0 Content-Type: multipart/mixed;boundary="----=_20080703110649_28315"


Content-Type: multipart/alternative;

boundary="8627fsu_trap_51382_94601130708002_=----"

Content-Transfer-Encoding: base64

--8627fsu_trap_51382_94601130708002_=---- Content-Type: text/plain Content-Transfer-Encoding: 8bit

...TEXT IS HERE...

--8627fsu_trap_51382_94601130708002_=---- Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: 8bit

...MORE TEXT... --8627fsu_trap_51382_94601130708002_=------


Content-Type: text/html; name="untitled-[1.2]" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="untitled-[1.2]"

...MORE TEXT...


Content-Type: image/jpeg; name="APT_adjust_focus.JPG" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="APT_adjust_focus.JPG"

...JPG DATA...

and so on.

Any help greatly appreciated. And a big "thank you" for mutt!

Change History

Changed 3 months ago by adamspiers

  • cc mutt-trac@… added

I also see this with 1.5.18. There are plenty of SquirrelMail? users out there, so a more graceful handling of this type of mail (even if it's violating RFCs) would be very gratefully received, thanks!

Changed 3 months ago by sertac

  • cc sertac.liste@… added

Changed 6 weeks ago by myon

Inlining the patch for better visibility:

--- mutt-1.5.16-orig/handler.c  2007-08-15 14:10:26.000000000 +0300
+++ mutt-1.5.16/handler.c       2007-08-15 14:10:05.000000000 +0300
@@ -1575,9 +1575,10 @@
     fseeko (s->fpin, b->offset, 0);
 
     /* see if we need to decode this part before processing it */
-    if (b->encoding == ENCBASE64 || b->encoding == ENCQUOTEDPRINTABLE ||
+    if (b->type != TYPEMULTIPART &&
+       (b->encoding == ENCBASE64 || b->encoding == ENCQUOTEDPRINTABLE ||
        b->encoding == ENCUUENCODED || plaintext || 
-       mutt_is_text_part (b))                          /* text subtypes may
+       mutt_is_text_part (b)))                         /* text subtypes may
                                                         * require character
                                                         * set conversion even
                                                         * with 8bit encoding.
--- mutt/PATCHES.old    Tue Nov  6 19:59:33 2001
+++ mutt/PATCHES        Tue Nov  6 19:59:42 2001
@@ -0,0 +1 @@
+sy.multipart_decode

Changed 6 weeks ago by tamo

  • keywords patch added

Changed 3 weeks ago by brendan

I wonder if changeset [f5fe657f0633] helps with this. Can you try a current nightly (see http://dev.mutt.org/nightlies/) and report how it handles these messages?

Changed 3 weeks ago by Michael Ashley

Hi Brendan,

Yep, that fixes it! I just tried mutt-20081116.tar.gz.

The other improvement I noticed is that the header cache is working
much more quickly that before. It only takes a fraction of a second to
get back to where I was with an inbox with 6500 messages.

Both improvements are very welcome!

Thank you,
regards, Michael

On Mon, Nov 17, 2008 at 04:30:12AM -0000, Mutt wrote:

Changed 3 weeks ago by brendan

  • status changed from new to closed
  • resolution set to fixed

Excellent, thanks for the quick feedback!

Note: See TracTickets for help on using tickets.